Bump android container to 7b4ffb683 #6826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albin-mullvad
force-pushed
the
bump-android-container-to-7b4ffb683
branch
from
a58eedc
to
5b47fc8
Compare
faern
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
build-apk.sh line 86 at r1 (raw file):
# NOTE: The version should match the one used in the checked in # maybenot.h file. cargo install --force cbindgen --version "0.26.0"
Great to have this removed! Since you can run build-apk.sh outside the container, it was very dirty to permanently globally install something for the invoker 😱
albin-mullvad
force-pushed
the
bump-android-container-to-7b4ffb683
branch
from
5b47fc8
to
6a39ca9
Compare
albin-mullvad
force-pushed
the
bump-android-container-to-7b4ffb683
branch
from
6a39ca9
to
4c7b69b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to bump the android container to a new version that includes
cbindgen.Fixes: DROID-1332
This change is